Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): don't add destroyAfterEach in newly generated spec files #21879

Merged
merged 1 commit into from
Oct 6, 2021
Merged

fix(@schematics/angular): don't add destroyAfterEach in newly generated spec files #21879

merged 1 commit into from
Oct 6, 2021

Conversation

alan-agius4
Copy link
Collaborator

This is now enabled by default.

See angular/angular#43353 for more context.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 6, 2021
@google-cla google-cla bot added the cla: yes label Oct 6, 2021
@alan-agius4 alan-agius4 added this to the v13 Feature Freeze milestone Oct 6, 2021
@alan-agius4 alan-agius4 changed the title feat(@schematics/angular): don't add destroyAfterEach in newly generated spec files. feat(@schematics/angular): don't add destroyAfterEach in newly generated spec files Oct 6, 2021
…ated spec files

This is now enabled by default.

See angular/angular#43353 for more context.
@alan-agius4 alan-agius4 removed this from the v13 Feature Freeze milestone Oct 6, 2021
@alan-agius4 alan-agius4 changed the title feat(@schematics/angular): don't add destroyAfterEach in newly generated spec files fix(@schematics/angular): don't add destroyAfterEach in newly generated spec files Oct 6, 2021
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Oct 6, 2021
@clydin clydin added this to the v13 Feature Freeze milestone Oct 6, 2021
@filipesilva filipesilva merged commit 585adac into angular:master Oct 6, 2021
@alan-agius4 alan-agius4 deleted the destroyAfterEach-remove branch October 6, 2021 19:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants