Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mark @angular-devkit/build-optimizer as deprecated. #21881

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Oct 6, 2021

It's functionality has been included in @angular-devkit/build-angular so this package is no longer needed by the CLI and we will stop publishing the package soon.

@dgp1130 dgp1130 added the target: major This PR is targeted for the next major release label Oct 6, 2021
@dgp1130 dgp1130 added this to the v13 Feature Freeze milestone Oct 6, 2021
@dgp1130 dgp1130 requested a review from clydin October 6, 2021 16:51
@google-cla google-cla bot added the cla: yes label Oct 6, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 6, 2021
@alan-agius4
Copy link
Collaborator

Nit: deprecations should be included in the commit message using DEPRECATED:.

https://github.com/angular/angular/blob/master/CONTRIBUTING.md

DEPRECATED: `@angular-devkit/build-optimizer`

It's functionality has been included in `@angular-devkit/build-angular` so this package is no longer needed by the CLI and we will stop publishing the package soon. It has been an experimental (never hit `1.0.0`) and internal (only used by Angular itself) package and should be not be used directly by others.
@dgp1130 dgp1130 force-pushed the build-optimizer-deprecation branch from dba0ef5 to 0083c81 Compare October 6, 2021 18:04
@dgp1130
Copy link
Collaborator Author

dgp1130 commented Oct 6, 2021

Thanks @alan-agius4, I was wondering about that. Updated the commit message.

@filipesilva filipesilva merged commit 5e435ff into angular:master Oct 6, 2021
@dgp1130 dgp1130 deleted the build-optimizer-deprecation branch October 6, 2021 22:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants