Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): don't export renderModuleFactory from server file #21894

Merged
merged 1 commit into from
Oct 7, 2021
Merged

fix(@schematics/angular): don't export renderModuleFactory from server file #21894

merged 1 commit into from
Oct 7, 2021

Conversation

alan-agius4
Copy link
Collaborator

Using renderModuleFactory is no longer needed since this was used for ViewEngine.

@alan-agius4 alan-agius4 added the target: rc This PR is targeted for the next release-candidate label Oct 7, 2021
@google-cla google-cla bot added the cla: yes label Oct 7, 2021
…ver file

Using `renderModuleFactory` is no longer needed since this was used for ViewEngine.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2021
@alan-agius4 alan-agius4 merged commit 94c00af into angular:master Oct 7, 2021
@alan-agius4 alan-agius4 deleted the remove-renderModuleFactory branch October 7, 2021 16:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants