Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): exclude packages from ng add that contain invalid peer dependencies #22022

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 26, 2021

Certain older versions of packages may contain missing or invalid peer dependencies. As a result these packages may be incorrectly added to the project when no newer compatible version is found. An exclusion list is now present within ng add that will exclude packages with known peer dependency concerns from consideration when adding a package. This will cause the fallback to the latest tag instead of installing a potentially very old and incompatible version. Currently, only @angular/localize@9.x is included in the list and is also no longer an actively supported version.

…peer dependencies

Certain older versions of packages may contain missing or invalid peer dependencies. As a result these packages may be incorrectly added to the project when no newer compatible version is found. An exclusion list is now present within `ng add` that will exclude packages with known peer dependency concerns from consideration when adding a package. Currently, only `@angular/localize@9.x` is included in the list.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Oct 26, 2021
@google-cla google-cla bot added the cla: yes label Oct 26, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 27, 2021
@filipesilva filipesilva merged commit 084eff6 into angular:master Oct 27, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants