Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): updated Angular new project version to v13.1.0 #22334

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Dec 10, 2021

New CLI projects are generated with Angular v13 (see https://github.com/cexbrayat/angular-cli-diff/blob/13.1.0/ponyracer/package.json) and TS v4.5 (which is only supported by Angular v13.1).

A new project is currently failing out of the box, as Angular v13 does not support TS 4.5.

npx @angular/cli@13.1.0 new v131 --defaults
cd v131
ng serve

throws:

UnhandledPromiseRejectionWarning: Error: The Angular Compiler requires TypeScript >=4.4.2 and <4.5.0 but 4.5.3 was found instead.
    at checkVersion (file:///Users/ced-pro/Code/test/cli-tests/v131/node_modules/@angular/compiler-cli/bundles/index.js:17440:11)

Fixes #22333

@alan-agius4
Copy link
Collaborator

@cexbrayat, can you please change the target of the PR to the 13.1 branch? Since on master this should pointing to ~13.2.0-next.0

@cexbrayat cexbrayat changed the base branch from master to 13.1.x December 10, 2021 08:41
@cexbrayat
Copy link
Member Author

@alan-agius4 Sure, done! I also opened #22337 to update master to v13.2 next if that can be useful.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 10, 2021
@alan-agius4 alan-agius4 merged commit a315b96 into angular:13.1.x Dec 10, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issue with 13.1.0
2 participants