Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/core): update missing workspace file error to explicitly call out angular.json #22353

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Dec 10, 2021

Internally, we've gotten a lot of bugs of users running the CLI in the wrong directory and not understanding this error. Hopefully calling this out more explicitly will key users to double-check their working directory before filing a bug.

…o explicitly call out `angular.json`

Internally, we've gotten a lot of bugs of users running the CLI in the wrong directory and not understanding this error. Hopefully calling this out more explicitly will key users to double-check their working directory before filing a bug.
@dgp1130 dgp1130 added the target: patch This PR is targeted for the next patch release label Dec 10, 2021
@dgp1130
Copy link
Collaborator Author

dgp1130 commented Dec 10, 2021

Equivalent google3 change in http://cl/415625079.

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4
Copy link
Collaborator

Nit: fix likely can be used as commit message type.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Dec 11, 2021
@alan-agius4 alan-agius4 merged commit f9187bc into angular:master Dec 11, 2021
@dgp1130 dgp1130 deleted the workspace-error branch December 14, 2021 01:04
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: devkit/core target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants