Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@schematics/angular): changed casings and small reorganizing #22417

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

fALKENdk
Copy link
Contributor

Updated casings so all categories starts with a capital letter and did some small reorganizations


# profiling files
# Profiling files
chrome-profiler-events*.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed since we no longer generate this file.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one small NIT

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Jan 10, 2022
@alan-agius4
Copy link
Collaborator

@fALKENdk, can you please squash the commits? Thanks.

Removed profiling files

Removed chrome-profiler-events*.json as it's no longer generated.
@fALKENdk fALKENdk force-pushed the update-caseings-gitignore-template branch from de83dcd to 0983750 Compare January 11, 2022 12:03
@fALKENdk
Copy link
Contributor Author

Hope I did it correct 😇

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 11, 2022
@alan-agius4
Copy link
Collaborator

@fALKENdk, you did!

@dgp1130 dgp1130 merged commit 08152f7 into angular:master Jan 12, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 12, 2022
@fALKENdk fALKENdk deleted the update-caseings-gitignore-template branch February 15, 2022 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants