-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ng update
E2E
#22596
Refactor ng update
E2E
#22596
Conversation
@dgp1130, the files in first commit were created via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change! Glad we can remove one more version bump.
Mainly just a question about how we depend on FW for this test.
With this change we update the `ng-update` test to start from version 10 as version 9 has been out of support for some time now.
We improve the migrations logic to automatically run the needed migrations based on the build version of the Angular CLI. This helps us to avoid having to manually update this test when we bump the major version. Example: https://github.com/angular/angular-cli/pull/22579/files
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
test(@angular/cli): remove hardcoded versions from ng-update test
We improve the migrations logic to automatically run the needed migrations based on the build version of the Angular CLI. This helps us to avoid having to manually update this test when we bump the major version. Example: https://github.com/angular/angular-cli/pull/22579/files
test(@angular/cli): update ng-update test to start from version 10
With this change we update the
ng-update
test to start from version 10 as version 9 has been out of support for some time now.