Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ng update E2E #22596

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Refactor ng update E2E #22596

merged 2 commits into from
Feb 2, 2022

Conversation

alan-agius4
Copy link
Collaborator

test(@angular/cli): remove hardcoded versions from ng-update test

We improve the migrations logic to automatically run the needed migrations based on the build version of the Angular CLI. This helps us to avoid having to manually update this test when we bump the major version. Example: https://github.com/angular/angular-cli/pull/22579/files

test(@angular/cli): update ng-update test to start from version 10

With this change we update the ng-update test to start from version 10 as version 9 has been out of support for some time now.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Jan 28, 2022
@alan-agius4
Copy link
Collaborator Author

@dgp1130, the files in first commit were created via npx @angular/cli@10 new ten-project.

Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change! Glad we can remove one more version bump.

Mainly just a question about how we depend on FW for this test.

tests/legacy-cli/e2e/tests/update/update-10.ts Outdated Show resolved Hide resolved
tests/legacy-cli/e2e/tests/update/update-10.ts Outdated Show resolved Hide resolved
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 31, 2022
@angular angular deleted a comment from ngbot bot Jan 31, 2022
With this change we update the `ng-update` test to start from version 10 as version 9 has been out of support for some time now.
We improve the migrations logic to automatically run the needed migrations based on the build version of the Angular CLI. This helps us to avoid having to manually update this test when we bump the major version. Example: https://github.com/angular/angular-cli/pull/22579/files
@alan-agius4 alan-agius4 removed the action: merge The PR is ready for merge by the caretaker label Jan 31, 2022
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 1, 2022
@dgp1130 dgp1130 merged commit 7212252 into angular:master Feb 2, 2022
@alan-agius4 alan-agius4 deleted the ng-update-fixes branch February 2, 2022 06:29
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants