feat(@schematics/angular): add migration to remove require calls from karma builder main file #23955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
alan-agius4
added
the
action: review
clydin
reviewed
Sep 26, 2022
| @@ -342,8 +342,7 @@ export async function getCommonConfig(wco: WebpackConfigOptions): Promise<Config | |||
| strictExportPresence: true, | |||
| parser: { | |||
| javascript: { | |||
| // TODO(alanagius): disable the below once we have a migration to remove `require.context` from test.ts file in users projects. | |||
| requireContext: true, | |||
| requireContext: false, | |||
There was a problem hiding this comment.
While this is not an officially supported feature, we might want to add a breaking change notice to let users know that this Webpack specific feature will definitely not work anymore. (And maybe reiterate that Webpack specific features are not guaranteed to work in the future.)
There was a problem hiding this comment.
Let’s do that.
alan-agius4
force-pushed
the
remove-require-calls
branch
from
5e9ddc3
to
1e56809
Compare
… karma builder main file With the recent changes in build-angular the `require.context` calls have become unneeded.
…sing `require.context` is a webpack specific feature which was only needed to support the old Karma test setup. BREAKING CHANGE: `require.context` are no longer parsed. Webpack specific features are not supported nor guaranteed to work in the future.
alan-agius4
force-pushed
the
remove-require-calls
branch
from
1e56809
to
578eb3d
Compare
clydin
approved these changes
Sep 26, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes in build-angular the
require.contextcalls have become unneeded.BREAKING CHANGE:
require.contextare no longer parsed. Webpack specific features are not supported nor guaranteed to work in the future.