Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): do not collect analytics when running in non TTY mode #24090

Merged
merged 1 commit into from Oct 14, 2022

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Oct 14, 2022

Prior to this change we collected analytics when config was not present and the CLI was running in non TTY mode.

Note: this only effects 15.0.0-next.5 package.

@alan-agius4 alan-agius4 added the target: rc This PR is targeted for the next release-candidate label Oct 14, 2022
@alan-agius4 alan-agius4 force-pushed the disable-analytics branch 2 times, most recently from 75170e2 to 61a67d9 Compare October 14, 2022 13:22
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 14, 2022
Prior to this change we collected analytics when config was not present and the CLI was running in non TTY mode.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 14, 2022
@alan-agius4 alan-agius4 merged commit 61fab64 into angular:main Oct 14, 2022
@alan-agius4 alan-agius4 deleted the disable-analytics branch October 14, 2022 13:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants