Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): skip node.js compatibility checks when running completion #24112

Merged
merged 1 commit into from Oct 24, 2022

Conversation

alan-agius4
Copy link
Collaborator

A warning at this stage could cause a broken source action (source <(ng completion script)) when in the shell init script.

Closes #24104

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 21, 2022
…pletion

A warning at this stage could cause a broken source action (`source <(ng completion script)`) when in the shell init script.

Closes angular#24104
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 24, 2022
@dgp1130 dgp1130 merged commit 1e4dbfd into angular:main Oct 24, 2022
@alan-agius4 alan-agius4 deleted the warning-node-completion branch October 24, 2022 22:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable Odd numbered Node.js version warning
3 participants