fix(@angular-devkit/build-angular): warn when components styles sourcemaps are not generated when styles optimization is enabled #24200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
clydin
approved these changes
Nov 8, 2022
packages/angular_devkit/build_angular/src/webpack/configs/styles.ts
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
sm-component-warn
branch
from
850954a
to
a3eea55
Compare
clydin
approved these changes
Nov 8, 2022
packages/angular_devkit/build_angular/src/webpack/configs/styles.ts
Outdated
Show resolved
Hide resolved
…emaps are not generated when styles optimization is enabled With this change we add a warning to inform the users that sourcemaps are not generated when both styles sourcemaps and optimization are enabled. This is because component style sourcemaps are inline which would drastically increase the bundle size. Closes angular#22834
alan-agius4
force-pushed
the
sm-component-warn
branch
from
af84e0b
to
5f9f209
Compare
alan-agius4
added
target: rc
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we add a warning to inform the users that sourcemaps are not generated when both styles sourcemaps and optimization are enabled. This is because component style sourcemaps are inline which would drastically increase the bundle size.
Closes #22834