Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@angular-devkit/build-angular): add assets option to server builder #24233

Merged
merged 2 commits into from Nov 18, 2022
Merged

feat(@angular-devkit/build-angular): add assets option to server builder #24233

merged 2 commits into from Nov 18, 2022

Conversation

alan-agius4
Copy link
Collaborator

This commits adds the assets option to the server builder. This can be useful to copy server specific assets such as config files.

Closes #24203

@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Nov 15, 2022
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Nov 15, 2022
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 15, 2022
@alan-agius4 alan-agius4 force-pushed the server-assets-option branch 2 times, most recently from affc5f9 to a588ce2 Compare November 15, 2022 10:46
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 15, 2022
@alan-agius4 alan-agius4 force-pushed the server-assets-option branch 3 times, most recently from 473ab0d to 89ee842 Compare November 15, 2022 13:04
@alan-agius4 alan-agius4 removed the request for review from clydin November 15, 2022 16:13
@alan-agius4 alan-agius4 added state: WIP and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 15, 2022
@alan-agius4 alan-agius4 force-pushed the server-assets-option branch 2 times, most recently from 42758b9 to 9c6ee36 Compare November 15, 2022 16:33
@alan-agius4
feat(@angular-devkit/build-angular): add assets option to server bu…
f578361 
…ilder

This commits adds the `assets` option to the server builder. This can be useful to copy server specific assets such as config files.

Closes angular#24203
@alan-agius4
test: remove target in tsconfig.server.json
3d5f876 
This is no longer needed as the CLI uses es2022 internally.
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 15, 2022
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 18, 2022
@dgp1130 dgp1130 merged commit 012746e into angular:main Nov 18, 2022
@alan-agius4 alan-agius4 deleted the server-assets-option branch November 18, 2022 19:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy assets with @angular-devkit/build-angular:server
3 participants
@alan-agius4 @clydin @dgp1130