Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix update test to work when @angular/cli and @angular/core majors diverge #24269

Merged
merged 1 commit into from Nov 18, 2022

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Nov 17, 2022

During releases, there is a brief time where @angular/core has released the next version, but @angular/cli has not. This test currently fails in such a situation because @angular/cli wasn't new enough to trigger the multiple versions upgrade. This fix upgrades @angular/core instead, so it will always be consistent.

This file on 15.0.x slightly diverged from main in #24249, so #24270 applies the same change there to avoid a merge conflict.

…ajors diverge

During releases, there is a brief time where `@angular/core` has released the next version, but `@angular/cli` has not. This test currently fails in such a situation because `@angular/cli` wasn't new enough to trigger the multiple versions upgrade. This fix upgrades `@angular/core` instead, so it will always be consistent.
@dgp1130 dgp1130 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Nov 17, 2022
@dgp1130 dgp1130 merged commit 51d17d4 into angular:15.0.x Nov 18, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants