Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular-devkit/build-angular): include sources in generated Sass source maps #24395

Merged
merged 1 commit into from Dec 8, 2022
Merged

fix(@angular-devkit/build-angular): include sources in generated Sass source maps #24395

merged 1 commit into from Dec 8, 2022

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 8, 2022 •
edited

This commits enables sourceMapIncludeSources when using the modern Sass API so that sources are included in generated source map.

Closes #24394

@alan-agius4 alan-agius4 changed the title fix(@amgular-devkit/build-angular): include sources in generated fix(@amgular-devkit/build-angular): include sources in generated Sass source map Dec 8, 2022
@alan-agius4 alan-agius4 changed the title fix(@amgular-devkit/build-angular): include sources in generated Sass source map fix(@amgular-devkit/build-angular): include sources in generated Sass source maps Dec 8, 2022
@alan-agius4 alan-agius4 marked this pull request as ready for review December 8, 2022 12:36
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 8, 2022
@alan-agius4 alan-agius4 changed the title fix(@amgular-devkit/build-angular): include sources in generated Sass source maps fix(@angular-devkit/build-angular): include sources in generated Sass source maps Dec 8, 2022
@alan-agius4
fix(@angular-devkit/build-angular): include sources in generated
15fc4bd 
Sass source maps

This commits enables `sourceMapIncludeSources` when using the modern Sass API so that sources are included in generated
source map.

Closes angular#24394
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 8, 2022
clydin
clydin approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is already handled with the experimental esbuild-based builder.

@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 8, 2022
@dgp1130 dgp1130 merged commit 27b22b0 into angular:main Dec 8, 2022
@alan-agius4 alan-agius4 deleted the sass-sourceMapIncludeSources branch December 9, 2022 05:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SCSS Debugging issue - Could not load content for webpack
3 participants
@alan-agius4 @clydin @dgp1130