New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non Bazel E2E CI jobs #24696
Merged
angular-robot
merged 6 commits into
angular:main
from
alan-agius4:remove-non-bazel-jobs
Feb 13, 2023
Merged
Remove non Bazel E2E CI jobs #24696
angular-robot
merged 6 commits into
angular:main
from
alan-agius4:remove-non-bazel-jobs
Feb 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
area: docs
Related to the documentation
area: build & ci
Related the build and CI infrastructure of the project
labels
Feb 10, 2023
This change removes all non Bazel E2E tests.
This commit updates the developer guide to include tips on how to run and debug tests when using the new Bazel E2E setup.
alan-agius4
force-pushed
the
remove-non-bazel-jobs
branch
15 times, most recently
from
February 10, 2023 16:46
3951d50
to
a404b2a
Compare
alan-agius4
added
the
target: minor
This PR is targeted for the next minor release
label
Feb 10, 2023
alan-agius4
requested review from
devversion and
clydin
and removed request for
devversion
February 10, 2023 16:46
alan-agius4
added
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
Feb 10, 2023
This commits removes some of the non Bazel related checks that are no longer required. This also fixes some issues with `bazel run`
This commit sets ups Node 18 tool chain and also configures E2E tests to use multiple tools chains to retain the same behaviour prior to switching the e2e tests to Bazel.
alan-agius4
force-pushed
the
remove-non-bazel-jobs
branch
from
February 10, 2023 17:16
a404b2a
to
b467bdf
Compare
This test is now failing, but this is the correct behaviour since we are using the public NPM registry.
clydin
approved these changes
Feb 10, 2023
Minor grammar fix. Co-authored-by: Charles <19598772+clydin@users.noreply.github.com>
alan-agius4
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Feb 10, 2023
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: build & ci
Related the build and CI infrastructure of the project
area: docs
Related to the documentation
target: minor
This PR is targeted for the next minor release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit.