Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non Bazel E2E CI jobs #24696

Merged
merged 6 commits into from Feb 13, 2023

Conversation

alan-agius4
Copy link
Collaborator

See each commit.

@angular-robot angular-robot bot added area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project labels Feb 10, 2023
This change removes all non Bazel E2E tests.
This commit updates the developer guide to include tips on how to run and debug tests when using the new Bazel E2E setup.
@alan-agius4 alan-agius4 force-pushed the remove-non-bazel-jobs branch 15 times, most recently from 3951d50 to a404b2a Compare February 10, 2023 16:46
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Feb 10, 2023
@alan-agius4 alan-agius4 requested review from devversion and clydin and removed request for devversion February 10, 2023 16:46
@alan-agius4 alan-agius4 marked this pull request as ready for review February 10, 2023 16:46
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 10, 2023
This commits removes some of the non Bazel related checks that are no longer required.

This also fixes some issues with `bazel run`
This commit sets ups Node 18 tool chain and also configures E2E tests to use multiple tools chains to retain the same behaviour prior to switching the e2e tests to Bazel.
This test is now failing, but this is the correct behaviour since we are using the public NPM registry.
@alan-agius4 alan-agius4 changed the title Remove non Bazel CI jobs Remove non Bazel E2E CI jobs Feb 10, 2023
docs/DEVELOPER.md Outdated Show resolved Hide resolved
Minor grammar fix.

Co-authored-by: Charles <19598772+clydin@users.noreply.github.com>
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 10, 2023
@angular-robot angular-robot bot merged commit afcc49f into angular:main Feb 13, 2023
@alan-agius4 alan-agius4 deleted the remove-non-bazel-jobs branch February 13, 2023 14:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: docs Related to the documentation target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants