Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): remove generation of BrowserModule.withServerTransition #24909

Merged

Conversation

alan-agius4
Copy link
Collaborator

This commit removes generation of .withServerTransition in the universal schematic as is deprecated.

DEPRECATED: the app-id option in the app-shell and universal schematics has been deprecated without replacement. See: angular/angular#49422 for more information about the rational of this change.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 24, 2023
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Mar 24, 2023
…rverTransition`

 This commit removes generation of `.withServerTransition` in the universal schematic as is deprecated.

 DEPRECATED: the `app-id` option in the app-shell and universal schematics has been deprecated without replacement. See: angular/angular#49422 for more information about the rational of this change.
@alan-agius4 alan-agius4 force-pushed the remove-with-server-transition branch from 8cd5c4a to 4c58318 Compare March 24, 2023 15:21
@alan-agius4 alan-agius4 requested a review from clydin March 24, 2023 15:39
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 24, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 24, 2023
@angular-robot angular-robot bot merged commit c9e84d0 into angular:main Mar 24, 2023
7 checks passed
@alan-agius4 alan-agius4 deleted the remove-with-server-transition branch March 24, 2023 21:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants