Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): support SSL options with esbuild development server #24955

Merged
merged 1 commit into from Apr 5, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 5, 2023

When using the esbuild-based browser application builder and its newly supported development server, the SSL related dev-server builder options can now be used. These include the existing ssl, sslCert, and sslKey options. Additionally, if no certificate and key are provided the @vitejs/plugin-basic-ssl plugin will be used to provide an auto-generated one. While not providing a certificate is possible, the browser will display a warning upon accessing the development server when using an auto-generated certificate.

@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Apr 5, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 5, 2023
@clydin clydin requested a review from alan-agius4 April 5, 2023 00:35
@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 5, 2023
@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 5, 2023
@clydin clydin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 5, 2023
… development server

When using the esbuild-based browser application builder and its newly supported development
server, the SSL related `dev-server` builder options can now be used. These include the existing
`ssl`, `sslCert`, and `sslKey` options. Additionally, if no certificate and key are provided
the `@vitejs/plugin-basic-ssl` plugin will be used to provide an auto-generated one.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 5, 2023
@clydin clydin added this to the v16 milestone Apr 5, 2023
@angular-robot angular-robot bot merged commit e4883b0 into angular:main Apr 5, 2023
21 checks passed
@clydin clydin deleted the esbuild/dev-server-ssl branch April 5, 2023 16:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants