Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@schematics/angular): remove copyright header from universal schematic files #24981

Conversation

brandonroberts
Copy link
Contributor

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Angular copyright headers are included in scaffolded files when adding Angular Universal support.

Issue Number: N/A

What is the new behavior?

The Angular copyright headers are no longer included in scaffolded files when adding Angular Universal support.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker labels Apr 10, 2023
@ngbot
Copy link

ngbot bot commented Apr 10, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: e2e-cli-npm" is failing
    failure status "ci/circleci: e2e-cli-yarn" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Apr 10, 2023

@brandonroberts, thanks for this.

@dgp1130
Copy link
Collaborator

dgp1130 commented Apr 11, 2023

@brandonroberts there was a CI issue with a recent update to lru-cache which should now be fixed. I think if you rebase CI should pass?

@brandonroberts brandonroberts force-pushed the fix-remove-universal-copyright-header branch from cce3a7e to 4982589 Compare April 11, 2023 17:33
@angular-robot angular-robot bot merged commit b0f6df2 into angular:main Apr 11, 2023
20 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Apr 11, 2023

Thanks @brandonroberts, merged it in!

@brandonroberts
Copy link
Contributor Author

Thanks @dgp1130!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants