Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(@angular-devkit/build-angular): enhance Sass package resolution in esbuild builder #24995

Merged
merged 1 commit into from Apr 12, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 11, 2023

The package module resolution logic for Sass stylesheets within the esbuild-based browser application builder has been restructured to limit the need to perform fallback resolution unless fully required. This allows common cases to avoid unnecessary and expensive resolution attempts. This provided a roughly 40% improvement in build times for the Angular Material documentation site.

…in esbuild builder

The package module resolution logic for Sass stylesheets within the esbuild-based browser
application builder has been restructured to limit the need to perform fallback resolution
unless fully required. This allows common cases to avoid unnecessary and expensive resolution
attempts. This provided a roughly 40% improvement in build times for the Angular Material
documentation site.
@clydin clydin added target: rc This PR is targeted for the next release-candidate action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 11, 2023
@clydin clydin requested a review from alan-agius4 April 11, 2023 22:44
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2023
@angular-robot angular-robot bot merged commit 11fa122 into angular:main Apr 12, 2023
23 checks passed
@clydin clydin deleted the esbuild/sass-resolve-perf branch April 12, 2023 18:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants