fix(@angular-devkit/build-angular): avoid double sourcemap comments with esbuild dev-server #25065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith esbuild dev-server When using the esbuild-based browser application builder with the dev-server builder, sourcemap URL comments were unintentionally doubled due to vite adding an additional inline sourcemap comment when processing the JavaScript files for the application. To avoid this, JavaScript files now have any sourcemap URL comments removed prior to being processed by vite. The sourcemap content is already passed directly to vite and allows the sourcemaps to be processed and provided to the browser as needed without the previously existing sourcemap URL comment. The removal is done without modifying the esbuild- based builder's options to avoid assuming the builder used with the dev-server has sourcemap options that allow hidden sourcemap generation.
clydin
added
action: review
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the esbuild-based browser application builder with the dev-server builder, sourcemap URL comments were unintentionally doubled due to vite adding an additional inline sourcemap comment when processing the JavaScript files for the application. To avoid this, JavaScript files now have any sourcemap URL comments removed prior to being processed by vite. The sourcemap content is already passed directly to vite and allows the sourcemaps to be processed and provided to the browser as needed without the previously existing sourcemap URL comment. The removal is done without modifying the esbuild-based builder's options to avoid assuming the builder used with the dev-server has sourcemap options that allow hidden sourcemap generation.