Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract i18n broken in v16 due to sourcemap issue #25413

Closed
1 task done
mattlewis92 opened this issue Jun 21, 2023 · 3 comments
Closed
1 task done

Extract i18n broken in v16 due to sourcemap issue #25413

mattlewis92 opened this issue Jun 21, 2023 · 3 comments

Comments

@mattlewis92
Copy link
Contributor

mattlewis92 commented Jun 21, 2023

Command

extract-i18n

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

15.x

Description

Extracting i18n is broken with certain libraries after upgrading to v16.

The issue appears to be in the sourcemap processing of the library, as deleting the libraries source map fixes the issue.

I tried upgrading the library to the latest v16 (npm i angular-calendar@next on the reproduction repo to try it) and confirmed the issue is still present so I think the issue must be fixed in the angular CLI itself (or in a dependency?)

Minimal Reproduction

git clone https://github.com/mattlewis92/angular-calendar-ng16-test.git
cd angular-calendar-ng16-test
npm i 
npx ng extract-i18n

Exception or Error

mattlewis@Matts-MacBook-Pro-3 angular-calendar-ng16-test % npx ng extract-i18n                                                                
✔ Browser application bundle generation complete.

Initial Chunk Files | Names         |  Raw Size
main.js             | main          |   1.96 MB | 
polyfills.js        | polyfills     | 120.30 kB | 
runtime.js          | runtime       |   6.38 kB | 

                    | Initial Total |   2.08 MB

Build at: 2023-06-21T12:35:46.006Z - Hash: 69af8508e517ec82 - Time: 2500ms

./node_modules/angular-calendar/fesm2020/angular-calendar.mjs - Error: Module build failed (from ./node_modules/@angular-devkit/build-angular/src/tools/babel/webpack-loader.js):
Error: /Users/mattlewis/Code/open-source/angular-calendar-ng16-test/node_modules/angular-calendar/fesm2020/angular-calendar.mjs: `column` must be greater than or equal to 0 (columns start

Your Environment

mattlewis@Matts-MacBook-Pro-3 angular-calendar-ng16-test % npx ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 16.1.0
Node: 18.16.0
Package Manager: npm 9.7.1
OS: darwin arm64

Angular: 16.1.1
... animations, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1601.0
@angular-devkit/build-angular   16.1.0
@angular-devkit/core            16.1.0
@angular-devkit/schematics      16.1.0
@angular/cli                    16.1.0
@schematics/angular             16.1.0
rxjs                            7.8.1
typescript                      5.1.3
    


### Anything else relevant?

_No response_
@geraldspreer
Copy link

I can confirm that this issue exists with both Angular 15 and Angular 16.

@clydin
Copy link
Member

clydin commented Jun 22, 2023

Duplicate of #25414

@clydin clydin marked this as a duplicate of #25414 Jun 22, 2023
@clydin clydin closed this as completed Jun 22, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants