Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): prevent race condition in setting up sass worker pool #25555

Merged
merged 1 commit into from Aug 3, 2023

Conversation

bgotink
Copy link
Contributor

@bgotink bgotink commented Jul 18, 2023

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Multiple calls to the SassStylesheetLanguage's process function can lead to setting up multiple sass worker pools, only one of which is cleaned up after the esbuild application build.

The result is ng build hanging forever waiting for the workers to exit.

Issue Number: N/A

What is the new behavior?

Prevent the race condition, thus setting up only one worker pool and allowing the process to exit gracefully.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@clydin clydin added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker labels Aug 3, 2023
@clydin clydin merged commit df4d358 into angular:main Aug 3, 2023
23 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants