Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/build-angular): normalize i18n options for application builder #25559

Merged
merged 1 commit into from Aug 31, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 19, 2023

The esbuild-based application builder will now access the project level i18n configuration as well as the builder localize, duplicateTranslationBehavior, and missingTranslationBehavior options to construct a full, normalized i18n option structure. These options are not yet used by the builder but they are now available to access as future work incrementally adds i18n support.

…pplication builder

The esbuild-based application builder will now access the project level i18n configuration
as well as the builder `localize`, `duplicateTranslationBehavior`, and `missingTranslationBehavior`
options to construct a full, normalized i18n option structure.
These options are not yet used by the builder but they are now available to access as future
work incrementally adds i18n support.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Jul 19, 2023
@alan-agius4
Copy link
Collaborator

@clydin is this ready for review?

@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Aug 30, 2023
@clydin clydin marked this pull request as ready for review August 30, 2023 14:19
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 31, 2023
@alan-agius4 alan-agius4 merged commit 1dcff01 into angular:main Aug 31, 2023
25 of 26 checks passed
@clydin clydin deleted the esbuild/i18n-options branch August 31, 2023 12:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants