test: update ssr test to use correct sha when testing ng add @angular/ssr
#25757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
snapshot-test-ssr-fix
branch
from
96733ea
to
4aa02cc
Compare
clydin
approved these changes
Aug 31, 2023
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
snapshot-test-ssr-fix
branch
3 times, most recently
from
268f149
to
c7a6c3e
Compare
…r/ssr` Before this change when running snapshot test, the schematic would add `@angular/platform-server` with the same version of `@angular/core`. This causing a problem when testing snapshots as the version is not a semver specifier but rather the path to the Github build repo. With this change, we ensure that the correct SHA is used for platform-server when running snapshot tests.
alan-agius4
force-pushed
the
snapshot-test-ssr-fix
branch
from
c7a6c3e
to
62ec563
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change when running snapshot test, the schematic would add
@angular/platform-serverwith the same version of@angular/core. This causing a problem when testing snapshots as the version is not a semver specifier but rather the path to the Github build repo.With this change, we ensure that the correct SHA is used for platform-server when running snapshot tests.