Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable E2E matrix testing fail fast option #25786

Merged
merged 1 commit into from Sep 6, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 5, 2023

To avoid unnecessary repeat runs of E2E CI matrix jobs due to flakes (especially with Windows), the fail-fast option for the E2E job has been disabled. This also allows for non-failing test jobs to complete in the case of a single test failure in a different E2E matrix test job.

@clydin clydin added the target: major This PR is targeted for the next major release label Sep 5, 2023
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Sep 5, 2023
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 5, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 6, 2023
To avoid unnecessary repeat runs of E2E CI matrix jobs due to flakes (especially
with Windows), the `fail-fast` option for the E2E job has been disabled. This also
allows for non-failing test jobs to complete in the case of a single test failure
in a different E2E matrix test job.
@dgp1130 dgp1130 merged commit ce687c1 into angular:main Sep 6, 2023
33 checks passed
@clydin clydin deleted the ci/disable-e2e-fail-fast branch September 6, 2023 16:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants