Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): support custom index option paths in Vite-based dev server #25808

Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 8, 2023

When using the Vite-based development server and a custom index build option (not index.html), the custom index path will now be used as the root of the development server. This mimics the behavior of the Webpack-based development server.

Fixes: #25806

@clydin clydin added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 8, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 8, 2023
@ngbot

This comment was marked as outdated.

… in Vite-based dev server

When using the Vite-based development server and a custom `index` build option (not `index.html`),
the custom index path will now be used as the root of the development server. This mimics the behavior
of the Webpack-based development server.
@clydin clydin force-pushed the dev-server/convert-custom-index-paths branch from 5c6b4a4 to ea776ce Compare September 8, 2023 17:54
@clydin clydin added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 8, 2023
@alan-agius4 alan-agius4 merged commit c11a0f0 into angular:main Sep 11, 2023
34 checks passed
@clydin clydin deleted the dev-server/convert-custom-index-paths branch September 11, 2023 11:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The builder @angular-devkit/build-angular:browser-esbuild not starting server for custom config
2 participants