Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update output regexp in i18n tests to account for change in filename #25888

Merged
merged 1 commit into from Sep 22, 2023

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 22, 2023

This update the regexp to account for the change in #25877. A filename that has the hash included will be main.[hash] in Webpack and main-[hash] when using esbuild.

@alan-agius4 alan-agius4 marked this pull request as ready for review September 22, 2023 09:35
…e name

This update the regexp to account for the change in angular#25877 A filename that has the hash included will be `main.[hash]` in Webpack and `main-[hash]` when using esbuild.
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 22, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 22, 2023
@alan-agius4 alan-agius4 merged commit 39b1976 into angular:main Sep 22, 2023
36 checks passed
@alan-agius4 alan-agius4 deleted the update-test branch September 22, 2023 09:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants