Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): enable hydration when adding SSR, SSG or AppShell #25889

Merged
merged 2 commits into from Sep 22, 2023

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 22, 2023

This commits updates the internal server schematic that is used by SSR and AppShell schematics to include provideClientHydration in the list of providers, which causes hydration to be enabled for application.

For more information about provideClientHydration, see: https://angular.io/api/platform-browser/provideClientHydration

FYI @AndrewKushnir

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 22, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Sep 22, 2023
@alan-agius4 alan-agius4 force-pushed the hydration-by-default branch 5 times, most recently from 7f1dcfd to 514eac9 Compare September 22, 2023 14:45
…ppShell

This commits updates the internal server schematic that is used by SSR and AppShell schematics to include `provideClientHydration` in the list of providers, which causes hydration to be enabled for application.

For more information about `provideClientHydration`, see: https://angular.io/api/platform-browser/provideClientHydration
…bledBlocking`

This removes that code that was used to set `initialNavigation: enabledBlocking` as this is no longer needed to reduce flickering. This is because `initialNavigation: enabledBlocking` is not needed when enabling hydration via `provideClientHydration` which is done in the internal server schematic.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 22, 2023
@alan-agius4 alan-agius4 merged commit fc68dca into angular:main Sep 22, 2023
33 checks passed
@alan-agius4 alan-agius4 deleted the hydration-by-default branch September 22, 2023 15:34
@alan-agius4 alan-agius4 changed the title feat(@schematics/angular): enable hydration when adding SSR, SSG or AppShell feat(@schematics/angular): enable hydration when adding SSR, SSG or AppShell Sep 25, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants