Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): support deploy URL option for browser-esbuild builder #25992

Merged
merged 1 commit into from Oct 10, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 9, 2023

The browser-esbuild builder now provides support for using the deployUrl option when building applications. This option is still considered deprecated which is the same status as with the Webpack-based browser application builder. This option is only available with the browser-esbuild builder and not other esbuild-based builders. The browser-esbuild builder is primarily intended to be used as a compatibility builder with the browser builder that requires only minimal changes to use.

@clydin clydin added the target: major This PR is targeted for the next major release label Oct 9, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 9, 2023
…rowser-esbuild` builder

The `browser-esbuild` builder now provides support for using the `deployUrl` option when building
applications.  This option is still considered deprecated which is the same status as with the
Webpack-based `browser` application builder. This option is only available with the `browser-esbuild`
builder and not other esbuild-based builders. The `browser-esbuild` builder is primarily intended
to be used as a compatibility builder with the `browser` builder that requires only minimal changes
to use.
@clydin clydin marked this pull request as ready for review October 9, 2023 23:59
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Oct 10, 2023
@alan-agius4 alan-agius4 merged commit 771e036 into angular:main Oct 10, 2023
35 checks passed
@clydin clydin deleted the esbuild/deploy-url branch October 10, 2023 14:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants