Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): remove the need to specify --migrate-only when --name is used during ng update #26082

Merged
merged 1 commit into from Oct 20, 2023

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Oct 20, 2023

This commit updates the behaviour of ng update --migrate-only to remove the need for --migrate-only option to be specified. --migrate-only will be set internally.

Before

ng update @angular/cli --migrate-only --name=migration-name

Now

ng update @angular/cli --name=migration-name

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Oct 20, 2023
@alan-agius4
Copy link
Collaborator Author

As discussed offline @dgp1130.

Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in commit message, I think you meant:

This commit updates the behaviour of ng update --name=some-migration to remove the need for --migrate-only option to be specified. --migrate-only will not be set internally.

Also shouldn't be be "--migration-only will be set internally"? Or am I misunderstanding the message?

packages/angular/cli/src/commands/update/cli.ts Outdated Show resolved Hide resolved
@alan-agius4
Copy link
Collaborator Author

Typo in commit message, I think you meant:

This commit updates the behaviour of ng update --name=some-migration to remove the need for --migrate-only option to be specified. --migrate-only will not be set internally.

Also shouldn't be be "--migration-only will be set internally"? Or am I misunderstanding the message?

Yes you are right

…--name` is used during `ng update`

This commit updates the behaviour of `ng update --migrate-only` to remove the need for `--migrate-only` option to be specified. `--migrate-only` will be set internally.

Before
```
ng update @angular/cli --migrate-only --name=migration-name
```

Now
```
ng update @angular/cli --name=migration-name
```
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 20, 2023
@alan-agius4 alan-agius4 removed the request for review from clydin October 20, 2023 20:54
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Oct 20, 2023
@alan-agius4 alan-agius4 merged commit 2c1c676 into angular:main Oct 20, 2023
35 checks passed
@alan-agius4 alan-agius4 deleted the update-migrate-only branch October 20, 2023 21:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants