Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esbuild is not reloading on asset only changes #26141

Open
1 task
iKrishnaSahu opened this issue Oct 26, 2023 · 5 comments
Open
1 task

esbuild is not reloading on asset only changes #26141

iKrishnaSahu opened this issue Oct 26, 2023 · 5 comments

Comments

@iKrishnaSahu
Copy link

Command

serve

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

esbuild is not detecting style changes when importing style file inside index.html

This issue does not happen in non esbuild builder

Minimal Reproduction

ng17rc1.zip

  • unzip above zip file and run npm install
  • check UI
  • now go to src\assets\ruf-default.css and update color property of header element to some other color
  • check if styles are reflecting on UI

Exception or Error

No response

Your Environment

_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 17.0.0-rc.1
Node: 18.18.2
Package Manager: npm 8.19.3
OS: win32 x64

Angular: 17.0.0-rc.1
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.0-rc.1
@angular-devkit/build-angular   17.0.0-rc.1
@angular-devkit/core            17.0.0-rc.1
@angular-devkit/schematics      17.0.0-rc.1
@schematics/angular             17.0.0-rc.1
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.0

Anything else relevant?

No response

@alan-agius4
Copy link
Collaborator

This is caused by at the moment, the page is not reloaded when only an asset change.

@clydin clydin changed the title esbuild is not detecting style changes esbuild is not reloading on asset only changes Oct 31, 2023
@bobbyg603

This comment was marked as off-topic.

@bobbyg603

This comment was marked as off-topic.

@ghost

This comment was marked as off-topic.

@blahblehblah
Copy link

still an issue on the 17.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@bobbyg603 @alan-agius4 @blahblehblah @iKrishnaSahu and others