perf(@angular-devkit/build-angular): patch fetch to load assets from memory
#26160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: rc
alan-agius4
force-pushed
the
server-assets-patch-fetch
branch
2 times, most recently
from
474768c
to
6d3dedb
Compare
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
server-assets-patch-fetch
branch
4 times, most recently
from
fb9af46
to
8a71484
Compare
clydin
approved these changes
Oct 29, 2023
packages/angular_devkit/build_angular/src/utils/server-rendering/fetch-patch.ts
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
server-assets-patch-fetch
branch
from
8a71484
to
f4ff55b
Compare
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
server-assets-patch-fetch
branch
from
f4ff55b
to
f60c9d4
Compare
…m memory This commit refactors the assets SSG asset loading from memory to use a patched version of `fetch` instead of spawning a separate server.
…tests This was previously disabled as it required updates in the framework.
alan-agius4
force-pushed
the
server-assets-patch-fetch
branch
from
f60c9d4
to
e11335d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the assets SSG asset loading from memory to use a patched version of
fetchinstead of spawning a separate server.