Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/build-angular): reduce complexity of bundle budget threshold regex #26194

Merged
merged 1 commit into from Nov 1, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 1, 2023

The extra whitespace matching can be removed via a trim call prior to matching and casing can be handled by the i flag.

…budget threshold regex

The extra whitespace matching can be removed via a trim call prior to matching and casing
can be handled by the `i` flag.
@clydin clydin marked this pull request as ready for review November 1, 2023 16:09
@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Nov 1, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 1, 2023
@alan-agius4 alan-agius4 merged commit 271d561 into angular:main Nov 1, 2023
35 of 36 checks passed
@clydin clydin deleted the bundle-budget-regex branch November 1, 2023 18:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants