refactor(@angular/ssr): use join instead of resolve
#26205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
clydin
approved these changes
Nov 2, 2023
alan-agius4
force-pushed
the
ssr-path-join
branch
5 times, most recently
from
1795229
to
52e5dc8
Compare
securityMB
reviewed
Nov 3, 2023
alan-agius4
added
action: merge
This change updates to code to guard against a potential path traversal. More context about the reasoning behind this change can be found in https://buganizer.corp.google.com/issues/299878755#comment26
alan-agius4
force-pushed
the
ssr-path-join
branch
from
52e5dc8
to
a5c793e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we replace
resolvewithjointo avoid potential path traversal vulnerability.More context about the reasoning behind this change can be found in https://buganizer.corp.google.com/issues/299878755#comment26
//cc @securityMB, @AndrewKushnir