Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): remove CJS usage warnings for inactionable packages #26217

Merged
merged 2 commits into from Nov 3, 2023

Conversation

alan-agius4
Copy link
Collaborator

This commit add critters and express to the CJS allowed deps.

@alan-agius4 alan-agius4 added this to the v17 milestone Nov 3, 2023
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Nov 3, 2023
…ctionable packages

This commit add `critters` and `express` to the CJS allowed deps.
…m render-worker

The `async` keyword is not needed here.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 3, 2023
@alan-agius4 alan-agius4 merged commit e453695 into angular:main Nov 3, 2023
33 checks passed
@alan-agius4 alan-agius4 deleted the common-js-checker branch November 3, 2023 13:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants