fix(@angular-devkit/build-angular): in vite skip SSR middleware for path with extensions #26222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
…ath with extensions Do not try to SSR a request that has extensions. Closes angular#26199
alan-agius4
force-pushed
the
asset-vite
branch
from
eaec605
to
f28358a
Compare
clydin
reviewed
Nov 3, 2023
packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts
Outdated
Show resolved
Hide resolved
clydin
approved these changes
Nov 3, 2023
Minor style change
alan-agius4
force-pushed
the
asset-vite
branch
from
eb6723e
to
e1262af
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not try to SSR a request that has extensions.
Closes #26199