refactor(@angular/pwa): use stream pipeline operator with HTML rewriter #26689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index HTML augmentation within the PWA schematic now uses the Node.js promise-based pipeline helper to reduce the complexity of the code when using the parse5 streaming rewriter. This removes a noticeable amount of code as well as removing the need to manually wrap the result in a Promise.
clydin
added
target: minor
alan-agius4
approved these changes
Dec 18, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index HTML augmentation within the PWA schematic now uses the Node.js promise-based pipeline helper to reduce the complexity of the code when using the parse5 streaming rewriter. This removes a noticeable amount of code as well as removing the need to manually wrap the result in a Promise.