refactor(@angular-devkit/build-angular): reduce promise creation during estimated transfer size calculation #26701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
esbuild/reduce-promises-transfer-size
branch
2 times, most recently
from
93083ad
to
1d1649b
Compare
…ng estimated transfer size calculation The promise creation overhead when calculating the estimated transfer size of the output files during an optimized build has been reduced by directly using the `brotliCompress` Node.js function instead of using a promisified variant. Node.js Only provides a callback-based async variant for brotli compression. This change allows for a single promise to be used.
clydin
force-pushed
the
esbuild/reduce-promises-transfer-size
branch
from
1d1649b
to
2196179
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Dec 19, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promise creation overhead when calculating the estimated transfer size of the output files during an optimized build has been reduced by directly using the
brotliCompressNode.js function instead of using a promisified variant. Node.js only provides a callback-based async variant for brotli compression. This change allows for a single promise to be used.