Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build: update dependency webpack-dev-middleware to v7" #26753

Merged
merged 1 commit into from Dec 27, 2023
Merged

Revert "build: update dependency webpack-dev-middleware to v7" #26753

merged 1 commit into from Dec 27, 2023

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 27, 2023 •
edited

Reverts #26750

The original change breaks Windows bazel build.

ERROR: D:/a/angular-cli/angular-cli/packages/angular_devkit/build_angular/BUILD.bazel:80:11: Compiling TypeScript (devmode) //packages/angular_devkit/build_angular:build_angular failed: missing input file 'external/npm/node_modules/json-joy/es2020/json-crdt/nodes/con/ConNode.d.ts', owner: '@npm//:node_modules/json-joy/es2020/json-crdt/nodes/con/ConNode.d.ts'
ERROR: D:/a/angular-cli/angular-cli/packages/angular_devkit/build_angular/BUILD.bazel:80:11: Compiling TypeScript (devmode) //packages/angular_devkit/build_angular:build_angular failed: missing input file 'external/npm/node_modules/json-joy/es6/json-crdt/nodes/con/ConNode.d.ts', owner: '@npm//:node_modules/json-joy/es6/json-crdt/nodes/con/ConNode.d.ts'
ERROR: D:/a/angular-cli/angular-cli/packages/angular_devkit/build_angular/BUILD.bazel:80:11: Compiling TypeScript (devmode) //packages/angular_devkit/build_angular:build_angular failed: missing input file 'external/npm/node_modules/json-joy/esm/json-crdt/nodes/con/ConNode.d.ts', owner: '@npm//:node_modules/json-joy/esm/json-crdt/nodes/con/ConNode.d.ts'
ERROR: D:/a/angular-cli/angular-cli/packages/angular_devkit/build_angular/BUILD.bazel:80:11: Compiling TypeScript (devmode) //packages/angular_devkit/build_angular:build_angular failed: missing input file 'external/npm/node_modules/json-joy/lib/json-crdt/nodes/con/ConNode.d.ts', owner: '@npm//:node_modules/json-joy/lib/json-crdt/nodes/con/ConNode.d.ts'
ERROR: D:/a/angular-cli/angular-cli/packages/angular_devkit/build_angular/BUILD.bazel:80:11: Compiling TypeScript (devmode) //packages/angular_devkit/build_angular:build_angular failed: missing input file 'external/npm/node_modules/json-joy/es2020/json-crdt/nodes/con/ConNode.js', owner: '@npm//:node_modules/json-joy/es2020/json-crdt/nodes/con/ConNode.js'
ERROR: D:/a/angular-cli/angular-cli/packages/angular_devkit/build_angular/BUILD.bazel:80:11: Compiling TypeScript (devmode) //packages/angular_devkit/build_angular:build_angular failed: missing input file 'external/npm/node_modules/json-joy/es6/json-crdt/nodes/con/ConNode.js', owner: '@npm//:node_modules/json-joy/es6/json-crdt/nodes/con/ConNode.js'
ERROR: D:/a/angular-cli/angular-cli/packages/angular_devkit/build_angular/BUILD.bazel:80:11: Compiling TypeScript (devmode) //packages/angular_devkit/build_angular:build_angular failed: missing input file 'external/npm/node_modules/json-joy/esm/json-crdt/nodes/con/ConNode.js', owner: '@npm//:node_modules/json-joy/esm/json-crdt/nodes/con/ConNode.js'
ERROR: D:/a/angular-cli/angular-cli/packages/angular_devkit/build_angular/BUILD.bazel:80:11: Compiling TypeScript (devmode) //packages/angular_devkit/build_angular:build_angular failed: missing input file 'external/npm/node_modules/json-joy/lib/json-crdt/nodes/con/ConNode.js', owner: '@npm//:node_modules/json-joy/lib/json-crdt/nodes/con/ConNode.js'

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Dec 27, 2023
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 27, 2023
@clydin clydin merged commit a5f5561 into main Dec 27, 2023
38 checks passed
@alan-agius4 alan-agius4 deleted the revert-26750-ng-renovate/webpack-dev-middleware-7-x branch December 27, 2023 14:05
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alan-agius4 @clydin