Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove outdated namespace syntax usage #26966

Merged
merged 1 commit into from Jan 26, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Jan 25, 2024

The namespace TypeScript usage within the CLI has been removed. This syntax is not recommended outside of type definition files.

Recommended to review with hide whitespace enabled.

@clydin clydin added the target: minor This PR is targeted for the next minor release label Jan 25, 2024
@clydin clydin force-pushed the build/remove-namespace-syntax branch from 2e2ce49 to 5d805d5 Compare January 25, 2024 19:38
The `namespace` TypeScript usage within the CLI has been removed. This
syntax is not recommended outside of type definition files.
@clydin clydin force-pushed the build/remove-namespace-syntax branch from 5d805d5 to 4693e67 Compare January 25, 2024 20:03
@clydin clydin marked this pull request as ready for review January 25, 2024 20:58
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 25, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 26, 2024
@alan-agius4 alan-agius4 merged commit 910531a into angular:main Jan 26, 2024
33 checks passed
@clydin clydin deleted the build/remove-namespace-syntax branch January 26, 2024 16:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants