fix(@angular-devkit/build-angular): avoid marking component styles as media with no output media directory #27183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
target: patch
… media with no output media directory The logic to detect media output files was previously predicated on the presence of a media subdirectory being defined. Prior to the ability to customize output path subcomponents there was a guaranteed media subdirectory. However, now that customization is possible, there is the potential for media files to not have a distinct subdirectory in the output. To facilitate output media detection in this scenario a file extension based method is now employed. This avoids a dependence on output directory structure.
clydin
force-pushed
the
application/component-media-detection
branch
from
d063fe8
to
a4e6abd
Compare
alan-agius4
approved these changes
Mar 4, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to detect media output files was previously predicated on the presence of a media subdirectory being defined. Prior to the ability to customize output path subcomponents there was a guaranteed media subdirectory. However, now that customization is possible, there is the potential for media files to not have a distinct subdirectory in the output. To facilitate output media detection in this scenario a file extension based method is now employed. This avoids a dependence on output directory structure.
Closes #27166