Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): improve Sass format clarity for application style option #27312

Merged
merged 1 commit into from Mar 19, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 18, 2024

The labels of the Sass preprocessor stylesheet option values have been updated for the application schematic's style option. The labels now provide greater clarity regarding the preprocessor tool used for both the SCSS (more common) and indented Sass syntaxes.

The new list selection prompt is now as follows:

? Which stylesheet format would you like to use? (Use arrow keys)
❯ CSS             [ https://developer.mozilla.org/docs/Web/CSS                     ]
  Sass (SCSS)     [ https://sass-lang.com/documentation/syntax#scss                ]
  Sass (Indented) [ https://sass-lang.com/documentation/syntax#the-indented-syntax ]
  Less            [ http://lesscss.org                                             ]

… style option

The labels of the Sass preprocessor stylesheet option values have been updated for
the `application` schematic's `style` option. The labels now provide greater
clarity regarding the preprocessor tool used for both the SCSS (more common) and
indented Sass syntaxes.

The new list selection prompt is now as follows:
```
? Which stylesheet format would you like to use? (Use arrow keys)
❯ CSS             [ https://developer.mozilla.org/docs/Web/CSS                     ]
  Sass (SCSS)     [ https://sass-lang.com/documentation/syntax#scss                ]
  Sass (Indented) [ https://sass-lang.com/documentation/syntax#the-indented-syntax ]
  Less            [ http://lesscss.org                                             ]
```
@clydin clydin added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 18, 2024
@clydin clydin requested a review from alan-agius4 March 19, 2024 11:19
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 19, 2024
@clydin clydin merged commit feef54a into angular:main Mar 19, 2024
35 checks passed
@clydin clydin deleted the schematics/style-prompt-text branch March 19, 2024 15:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants