Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 prerender performance mark has not been set #27374

Closed
1 task
Tenessy opened this issue Mar 27, 2024 · 2 comments
Closed
1 task

Angular 17 prerender performance mark has not been set #27374

Tenessy opened this issue Mar 27, 2024 · 2 comments
Assignees
Labels
needs: more info Reporter must clarify the issue

Comments

@Tenessy
Copy link

Tenessy commented Mar 27, 2024

Command

build, serve

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

An issue is present when I use "enablePerformanceProfiler" with new commonEngine in server.ts file to show the SSR performance with an application build in prerender SSG.

This error show when I have routes not prerender and just SSR version of my page. This error return a status error 500 when I use a simulator of crawl like Screaming Frog SEO spider.

Minimal Reproduction

  • ng build application with configuration angular.json with prerender RoutesFiles options and discoverRoutes False.
  • serve application in SSR (node dist/PROJECT_NAME/server/server.mjs)
  • refresh page who hasn't prerender route or use a simulator of crawl like Screaming Frog SEO spider

Exception or Error

SyntaxError:
The "start: Retrieve SSG Page" performance mark has not been set
at new DOMException (node: internal/per context/domexception: 53:5)
at _node_internal (node: Internal/utiT: 670:10) at getMark (node: internal/perf/usertiming:58:11)
at calculateStartDuration (node: internal/perf/usertiming: 142:13)
at Performance. measure (node: internal/perf/usertiming: 160:7)

Your Environment

Angular CLI: 17.3.2
Node: 18.19.0
Package Manager: npm 10.2.3
OS: darwin arm64

Angular: 17.3.1
... animations, cdk, common, compiler, compiler-cli, core, forms
... material, platform-browser, platform-browser-dynamic
... platform-server, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1703.2
@angular-devkit/build-angular   17.3.2
@angular-devkit/core            17.3.2
@angular-devkit/schematics      17.3.2
@angular/cli                    17.3.2
@angular/ssr                    17.3.2
@schematics/angular             17.3.2
rxjs                            7.8.1
typescript                      5.3.3
zone.js                         0.14.4

Anything else relevant?

No response

@alan-agius4 alan-agius4 added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely area: @angular/ssr severity3: broken labels Apr 1, 2024
@alan-agius4 alan-agius4 self-assigned this Apr 1, 2024
@alan-agius4 alan-agius4 added needs: more info Reporter must clarify the issue and removed type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: @angular/ssr labels Apr 9, 2024
@alan-agius4
Copy link
Collaborator

Hi @Tenessy, I am unable to replicate this mentioned issue.

$ node server.mjs 
Node Express server listening on http://localhost:4000
********** Performance results **********
Retrieve SSG Page:       2.3ms
Render Page:             720.8ms
Inline Critical CSS:     17.2ms
*****************************************
********** Performance results **********
Retrieve SSG Page:       0.5ms
Render Page:             391.0ms
Inline Critical CSS:     4.3ms
*****************************************
********** Performance results **********
Retrieve SSG Page:       0.5ms
Render Page:             1832.1ms
Inline Critical CSS:     3.7ms
*****************************************
********** Performance results **********
Retrieve SSG Page:       0.5ms
Render Page:             110.7ms
Inline Critical CSS:     4.1ms
*****************************************
********** Performance results **********
Retrieve SSG Page:       0.6ms
Render Page:             1568.4ms
Inline Critical CSS:     2.4ms
*****************************************
********** Performance results **********
Retrieve SSG Page:       0.7ms
Render Page:             903.4ms
Inline Critical CSS:     2.4ms
*****************************************
********** Performance results **********
Retrieve SSG Page:       0.5ms
Render Page:             106.2ms
Inline Critical CSS:     2.3ms
*****************************************
********** Performance results **********
Retrieve SSG Page:       0.9ms
Render Page:             198.0ms
Inline Critical CSS:     2.3ms
*****************************************

@alan-agius4
Copy link
Collaborator

I'm sorry, but we can't reproduce the problem following the instructions you provided.
Remember that we have a large number of issues to resolve, and have only a limited amount of time to reproduce your issue.
Short, explicit instructions make it much more likely we'll be able to reproduce the problem so we can fix it.

If the problem persists, please open a new issue following our submission guidelines.

A good way to make a minimal repro is to create a new app via ng new repro-app and add the minimum possible code to show the problem. Then you can push this repository to github and link it here.

@alan-agius4 alan-agius4 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: more info Reporter must clarify the issue
Projects
None yet
Development

No branches or pull requests

2 participants