Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update all non-major dependencies #27390

Merged
merged 2 commits into from Apr 2, 2024

Conversation

alan-agius4
Copy link
Collaborator

No description provided.

@alan-agius4 alan-agius4 requested a review from clydin March 30, 2024 18:38
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Mar 30, 2024
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 30, 2024
@alan-agius4 alan-agius4 force-pushed the all-major-deps-4 branch 2 times, most recently from 3740ce4 to 86bb45d Compare April 2, 2024 16:23
@alan-agius4 alan-agius4 requested a review from dgp1130 April 2, 2024 16:24
@@ -78,7 +78,7 @@
"@babel/preset-env": "7.24.3",
"@babel/runtime": "7.24.1",
"@bazel/bazelisk": "1.19.0",
"@bazel/buildifier": "7.1.0",
"@bazel/buildifier": "6.4.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this downgrade intentional? Was there some conflict with 7.1.0 and other updates in this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is intentional see: 86bb45d

This dep was only updated in main

@alan-agius4 alan-agius4 removed the request for review from clydin April 2, 2024 16:39
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 2, 2024
angular-robot and others added 2 commits April 2, 2024 16:51
This reverts commit ea55c48.

Reverted as this is causing `load-on-top` warnings in the WORKSPACE file. Which appears to be the cause of using `buildifier` version 7 with Bazel 5.
@alan-agius4 alan-agius4 merged commit 16d8c55 into angular:main Apr 2, 2024
32 checks passed
@alan-agius4 alan-agius4 deleted the all-major-deps-4 branch April 2, 2024 17:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants