feat(@angular-devkit/build-angular): move i18n extraction for application builder to new build system package #27519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
application/split-extract-i18n
branch
3 times, most recently
from
6944b31
to
4655881
Compare
…tion builder to new build system package With the `application` builder already within the new `@angular/build` package, the `extract-i18n` builder with application builder support is now also contained within this package. Only the application builder aspects of `extract-i18n` have been moved. The compatibility builder `browser-esbuild` is not supported with `@angular/build:extract-i18n`. The existing `extract-i18n` builder found within `@angular-devkit/build-angular` should continue to be used for both the Webpack-based `browser` builder and the esbuild-based compatibility `browser-esbuild` builder. To maintain backwards compatibility, the existing `@angular-devkit/build-angular:extract-i18n` builder continues to support builders it has previously. No change to existing applications is required.
clydin
force-pushed
the
application/split-extract-i18n
branch
from
4655881
to
48b6383
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Apr 24, 2024
alan-agius4
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
applicationbuilder already within the new@angular/buildpackage, theextract-i18nbuilder with application builder support is now also contained within this package. Only the application builder aspects ofextract-i18nhave been moved. The compatibility builderbrowser-esbuildis not supported with@angular/build:extract-i18n. The existingextract-i18nbuilder found within@angular-devkit/build-angularshould continue to be used for both the Webpack-basedbrowserbuilder and the esbuild-based compatibilitybrowser-esbuildbuilder. To maintain backwards compatibility, the existing@angular-devkit/build-angular:extract-i18nbuilder continues to support builders it has previously.No change to existing applications is required.