Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app doesnt rebuild when error in sass function is fixed #27750

Closed
1 task
Siddhu-K opened this issue May 30, 2024 · 3 comments · Fixed by #27763
Closed
1 task

app doesnt rebuild when error in sass function is fixed #27750

Siddhu-K opened this issue May 30, 2024 · 3 comments · Fixed by #27763
Assignees
Labels
angular/build:application area: angular/build area: docs Related to the documentation freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix

Comments

@Siddhu-K
Copy link

Command

serve

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

I am in the process of migrating to m3.
I noticed that when mat.get-theme-color($theme, primary-container) gets an invalid parameter, I get an error in the terminal and fixing the parameter does not trigger a rebuild. I need to rerun ng s

Minimal Reproduction

Use mat.get-theme-color with incorrect color type like 'warn'.

ERROR
Valid color roles are: .......... Got: warn

fix warn with correct color type 'error'

app doesnt rebuild

Exception or Error

No response

Your Environment

Angular CLI: 18.0.2
Node: 20.11.1
Package Manager: npm 10.8.1
OS: win32 x64

Angular: 18.0.1
... animations, cdk, common, compiler, compiler-cli, core, forms
... google-maps, material, material-moment-adapter
... platform-browser, platform-browser-dynamic, router
... service-worker

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1800.2
@angular-devkit/core         18.0.2
@angular-devkit/schematics   18.0.2
@angular/build               18.0.2
@angular/cli                 18.0.2
@schematics/angular          18.0.2
rxjs                         7.8.1
typescript                   5.4.5
zone.js                      0.14.6

Anything else relevant?

No response

@alan-agius4
Copy link
Collaborator

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?

You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

@alan-agius4 alan-agius4 added the needs: repro steps We cannot reproduce the issue with the information given label May 30, 2024
@Siddhu-K
Copy link
Author

@alan-agius4 I have created a minimal-repo.

https://github.com/Siddhu-K/repro-app

When I change the 'warn' to an accepted value such as 'error' in the component-theme.scss, the app doesn't rebuild. I need to terminate the process with 'ctrl+c' or kill the terminal and then run 'ng s' for it to work.

@alan-agius4 alan-agius4 added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: docs Related to the documentation angular/build:application area: angular/build and removed needs: repro steps We cannot reproduce the issue with the information given labels May 31, 2024
@clydin clydin self-assigned this May 31, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
angular/build:application area: angular/build area: docs Related to the documentation freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants