Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular/cli): ignore ts-node when attempting to run karma with a linked cli #4997

Merged
merged 1 commit into from Feb 25, 2017
Merged

fix(@angular/cli): ignore ts-node when attempting to run karma with a linked cli #4997

merged 1 commit into from Feb 25, 2017

Conversation

delasteve
Copy link
Contributor

@delasteve delasteve commented Feb 25, 2017 •
edited by filipesilva

Fix #4568

@delasteve delasteve changed the title fix(@angular-cli): ignore ts-node when attempting to run karma with a linked cli fix(@angular/cli): ignore ts-node when attempting to run karma with a linked cli Feb 25, 2017
@delasteve delasteve force-pushed the fix/link-cli-test branch 2 times, most recently from 5cd6d83 to 1748cba Compare February 25, 2017 13:05
@filipesilva
Copy link
Contributor

Tested myself and works great, cheers!

@filipesilva filipesilva merged commit 7b8f692 into angular:master Feb 25, 2017
@filipesilva filipesilva mentioned this pull request Feb 25, 2017
Closed
@delasteve delasteve deleted the fix/link-cli-test branch March 16, 2017 22:07
@tylerlindell
Copy link

I just grabbed angular-cli using latest npm and get the error when running ng e2e. Should I grab a specific branch to get that to work?

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@delasteve
fix(@angular/cli): ignore ts-node when attempting to run karma with a…
c67d4ba 
… linked cli (angular#4997)

fixes angular#4568, angular#4177
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ng test fails, is unable to compile TypeScript
4 participants
@delasteve @filipesilva @tylerlindell @googlebot