Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@ngtools/webpack): fix paths-plugin to allow '*' as alias #5033

Closed
wants to merge 1 commit into from
Closed

fix(@ngtools/webpack): fix paths-plugin to allow '*' as alias #5033

wants to merge 1 commit into from

Conversation

chrisfitz
Copy link
Contributor

@chrisfitz chrisfitz commented Feb 27, 2017

This is a follow up to #3443 that didn't quite fix #3441. The current behavior will throw an out of memory or recursion in resolving error if you attempt to use an * as a path alias within the tsconfig.json file.

(Sorry for duplicate PR, seems like GitHub lost track of my branch and auto-closed the last one).

@filipesilva filipesilva requested a review from hansl March 8, 2017 22:41
@filipesilva
Copy link
Contributor

@hansl can you review?

@Brocco
Copy link
Contributor

Brocco commented May 24, 2017

This commit was merged... 6da95cd

@LarryBattleWork
Copy link

LarryBattleWork commented May 25, 2017

This commit breaks the old test for tests/e2e/tests/build/ts-paths.ts.

node tests/run_e2e.js tests/e2e/tests/build/ts-paths.ts

Output:

...
Error: Running "ng build --no-progress" returned error code 1...

STDOUT:
Hash: 343c3cc2860e0ad4311e
Time: 6839ms
chunk    {0} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 158 kB {4} [initial] [rendered]
chunk    {1} main.bundle.js, main.bundle.js.map (main) 4.15 kB {3} [initial] [rendered]
chunk    {2} styles.bundle.js, styles.bundle.js.map (styles) 10.5 kB {4} [initial] [rendered]
chunk    {3} vendor.bundle.js, vendor.bundle.js.map (vendor) 2.1 MB [initial] [rendered]
chunk    {4} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]

ERROR in ./src/app/app.component.ts
Module not found: Error: Can't resolve 'app/shared/meaning' in '/private/var/folders/06/6tlhnj4106x28wzdjspkn1ww0000gp/T/angular-cli-e2e-117425-81429-1yx54ji.tqn2l3ow29/test-project/src/app'
 @ ./src/app/app.component.ts 22:0-45
 @ ./src/app/app.module.ts
 @ ./src/main.ts
 @ multi ./src/main.ts
...

hansl added a commit to hansl/angular-cli that referenced this pull request Aug 2, 2017
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 2, 2017
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 2, 2017
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 2, 2017
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 2, 2017
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 2, 2017
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 2, 2017
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.

This is a feature because we do not want it in 1.3.0
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 3, 2017
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.

This is a feature because we do not want it in 1.3.0
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 3, 2017
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.

This is a feature because we do not want it in 1.3.0
hansl added a commit that referenced this pull request Aug 9, 2017
This is a similar version of #5033. Reverted in #6463 because of issue #6451.

This is a feature because we do not want it in 1.3.0
hansl added a commit that referenced this pull request Aug 9, 2017
This is a similar version of #5033. Reverted in #6463 because of issue #6451.

This is a feature because we do not want it in 1.3.0
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
This is a similar version of angular#5033. Reverted in angular#6463 because of issue angular#6451.

This is a feature because we do not want it in 1.3.0
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngtools/webpack fails when using "*" as tsconfig paths alias
6 participants