Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@ngtools/webpack): replace server bootstrap code #5194

Merged
merged 7 commits into from
May 22, 2017

Conversation

FrozenPandaz
Copy link
Contributor

Currently the loader is only replacing the bootstrap code of platformBrowser.

It should replace the bootstrap code of platformServer as well.

I also made it expandable to other platforms. We should probably add webworker platform as well.

I can do that in a separate pull request?

Motivation for this is better support of platform-server via @ngtools/webpack

@FrozenPandaz
Copy link
Contributor Author

cc @hansl @filipesilva

@filipesilva
Copy link
Contributor

@FrozenPandaz can you add a test that shows these changes work?

A good place to add would be side by side with the other webpack plugin tests in https://github.com/angular/angular-cli/tree/master/tests/e2e/tests/packages/webpack

These tests will create a new project from the files in https://github.com/angular/angular-cli/tree/master/tests/e2e/assets/webpack.

You'll need a new project in the last folder, and a new file that tests it in the first.

@FrozenPandaz
Copy link
Contributor Author

@filipesilva yes i will add tests, thanks for pointing me to the right place i was actually confused about that because theres a loader spec which looks quite empty.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@FrozenPandaz
Copy link
Contributor Author

@filipesilva I've added tests. Please take a look.

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on the test setup! I'm requesting Hans's review on this as the authority on the plugin.

@filipesilva filipesilva requested a review from hansl March 18, 2017 15:49
@FrozenPandaz FrozenPandaz force-pushed the refactor-platform-server branch 2 times, most recently from 9304bb7 to 24a6914 Compare March 24, 2017 17:52
@FrozenPandaz
Copy link
Contributor Author

I rebased this again. @hansl

@demurgos
Copy link
Contributor

Could you provide some updates about this issue ?

@Reuvenc
Copy link

Reuvenc commented Apr 23, 2017

Anything new regarding this PR? It is extremely important for our project.

@FrozenPandaz FrozenPandaz force-pushed the refactor-platform-server branch 5 times, most recently from a4894bf to e61fae4 Compare April 30, 2017 03:20
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 4, 2017
@FrozenPandaz FrozenPandaz force-pushed the refactor-platform-server branch 3 times, most recently from 9a7716f to 016445e Compare May 4, 2017 04:30
@FrozenPandaz
Copy link
Contributor Author

@hansl This should be ready for you to take a look

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hansl hansl merged commit c268b58 into angular:master May 22, 2017
GulajavaMinistudio added a commit to angular-indonesia/angular-cli that referenced this pull request May 22, 2017
feat(@ngtools/webpack): replace server bootstrap code (angular#5194)
GulajavaMinistudio added a commit to GulajavaMinistudio/angular-cli that referenced this pull request May 22, 2017
feat(@ngtools/webpack): replace server bootstrap code (angular#5194)
@MarkPieszak
Copy link
Member

Saw it merged to master, any ideas when we're releasing to npm?
@hansl

@paulogr
Copy link

paulogr commented May 23, 2017

Is this depends on #5547?

@FrozenPandaz
Copy link
Contributor Author

Nope this does not depend on #5547

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants